server: enable KVM volume and VM snapshot by default #11446

rohityadavcloud · 2025-08-14T10:55:30Z

Given EL6/EL7 is deprecated now and most modern supported KVM distros ship newer versions of qemu, KVM volume and VM snapshot can be enabled by default.

Fixes #11445

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

rohityadavcloud · 2025-08-14T10:56:11Z

@blueorangutan package

blueorangutan · 2025-08-14T10:58:04Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-08-14T11:07:20Z

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (a15fbd9) to head (129f6c7).
⚠️ Report is 19 commits behind head on main.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11446      +/-   ##
============================================
+ Coverage     17.53%   17.56%   +0.02%     
- Complexity    15463    15498      +35     
============================================
  Files          5897     5898       +1     
  Lines        527397   527777     +380     
  Branches      64407    64473      +66     
============================================
+ Hits          92505    92704     +199     
- Misses       424496   424650     +154     
- Partials      10396    10423      +27

Flag	Coverage Δ
uitests	`3.59% <ø> (-0.01%)`	⬇️
unittests	`18.63% <66.66%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-08-14T12:08:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14624

slavkap

Code LGTM.
Thanks for this change

DaanHoogland · 2025-08-14T16:06:25Z

@blueorangutan test keepEnv

blueorangutan · 2025-08-14T16:08:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-08-15T08:44:51Z

[SF] Trillian test result (tid-14062)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57050 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11446-t14062-kvm-ol8.zip
Smoke tests completed. 144 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_13_retrieve_vr_default_files	`Error`	1.12	test_diagnostics.py
test_14_retrieve_vr_one_file	`Error`	1.12	test_diagnostics.py
test_15_retrieve_ssvm_default_files	`Error`	1.12	test_diagnostics.py
test_16_retrieve_ssvm_single_file	`Error`	1.12	test_diagnostics.py
test_17_retrieve_cpvm_default_files	`Error`	0.11	test_diagnostics.py
test_18_retrieve_cpvm_single_file	`Error`	1.12	test_diagnostics.py
test_01_deployVMInSharedNetwork	`Failure`	433.85	test_network.py

sureshanaparti

clgtm

DaanHoogland

clgtm

server/src/main/java/com/cloud/configuration/Config.java

harikrishna-patnala · 2025-09-03T10:38:25Z

@blueorangutan package

blueorangutan · 2025-09-03T10:40:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-03T11:53:11Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14827

rohityadavcloud · 2025-09-03T14:53:54Z

@blueorangutan test

blueorangutan · 2025-09-03T14:56:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-04T07:21:05Z

[SF] Trillian test result (tid-14202)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56044 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11446-t14202-kvm-ol8.zip
Smoke tests completed. 145 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_site2site_vpn_multiple_options	`Failure`	270.70	test_vpc_vpn.py

harikrishna-patnala

LGTM

github-actions · 2025-09-27T03:35:02Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

blueorangutan · 2025-10-08T12:20:53Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15344

harikrishna-patnala · 2025-10-08T15:41:25Z

@blueorangutan package

blueorangutan · 2025-10-08T15:42:04Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-08T17:04:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15347

harikrishna-patnala · 2025-10-09T05:06:15Z

@blueorangutan test

blueorangutan · 2025-10-09T05:08:07Z

@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-10-09T06:01:17Z

[SF] Trillian Build Failed (tid-14593)

harikrishna-patnala · 2025-10-09T07:01:56Z

@blueorangutan test

blueorangutan · 2025-10-09T07:04:03Z

@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

nvazquez

Thanks @rohityadavcloud - perhaps this also needs addressing for vanilla envs? https://github.com/apache/cloudstack/blob/main/engine/schema/src/main/resources/META-INF/db/schema-410to420.sql#L2308 cc @rosi-shapeblue

blueorangutan · 2025-10-09T22:35:23Z

[SF] Trillian test result (tid-14596)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52642 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11446-t14596-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

rohityadavcloud · 2025-10-10T04:09:14Z

Thanks for catching @nvazquez @rosi-shapeblue - I've fixed the concerned old upgrade path. Rekicking packaging.

@blueorangutan package

blueorangutan · 2025-10-10T04:10:04Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Signed-off-by: Rohit Yadav <[email protected]>

rohityadavcloud · 2025-10-10T04:11:44Z

@blueorangutan package

blueorangutan · 2025-10-10T04:14:06Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-10T06:44:44Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15384

blueorangutan · 2025-10-10T06:45:02Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15385

weizhouapache

code lgtm

DaanHoogland · 2025-10-10T14:37:48Z

@blueorangutan test

blueorangutan · 2025-10-10T14:40:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-10-10T15:13:21Z

[SF] Trillian Build Failed (tid-14623)

rosi-shapeblue

LGTM - settings are enabled by default

Signed-off-by: Rohit Yadav <[email protected]>

boring-cyborg bot added the component:storage label Aug 14, 2025

rohityadavcloud requested review from DaanHoogland, harikrishna-patnala and sureshanaparti August 14, 2025 10:55

rohityadavcloud added this to the 4.22.0 milestone Aug 14, 2025

boring-cyborg bot added the component:management-server label Aug 14, 2025

slavkap approved these changes Aug 14, 2025

View reviewed changes

sureshanaparti approved these changes Aug 15, 2025

View reviewed changes

harikrishna-patnala added this to Apache CloudStack 4.22.0 Aug 19, 2025

DaanHoogland approved these changes Aug 20, 2025

View reviewed changes

DaanHoogland added the status:needs-testing label Aug 20, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 20, 2025

harikrishna-patnala reviewed Sep 3, 2025

View reviewed changes

server/src/main/java/com/cloud/configuration/Config.java Outdated Show resolved Hide resolved

harikrishna-patnala force-pushed the enable-kvm-snapshot-by-default branch from 3666263 to 8bb7d90 Compare September 3, 2025 10:37

harikrishna-patnala approved these changes Sep 8, 2025

View reviewed changes

github-actions bot added the status:has-conflicts label Sep 27, 2025

rosi-shapeblue self-assigned this Oct 9, 2025

nvazquez reviewed Oct 9, 2025

View reviewed changes

enable kvm.snaphot.enabled in old upgrade path

129f6c7

Signed-off-by: Rohit Yadav <[email protected]>

weizhouapache approved these changes Oct 10, 2025

View reviewed changes

nvazquez approved these changes Oct 10, 2025

View reviewed changes

rosi-shapeblue approved these changes Oct 10, 2025

View reviewed changes

rosi-shapeblue removed the status:needs-testing label Oct 12, 2025

DaanHoogland merged commit 1e23d6b into apache:main Oct 13, 2025
27 of 28 checks passed

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Oct 13, 2025

DaanHoogland deleted the enable-kvm-snapshot-by-default branch October 13, 2025 07:53

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025

server: enable KVM volume and VM snapshot by default (apache#11446)

b29c3fe

Signed-off-by: Rohit Yadav <[email protected]>

server: enable KVM volume and VM snapshot by default #11446

server: enable KVM volume and VM snapshot by default #11446

Uh oh!

Conversation

rohityadavcloud commented Aug 14, 2025

Types of changes

Uh oh!

rohityadavcloud commented Aug 14, 2025

Uh oh!

blueorangutan commented Aug 14, 2025

Uh oh!

codecov bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Aug 14, 2025

Uh oh!

slavkap left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Aug 14, 2025

Uh oh!

blueorangutan commented Aug 14, 2025

Uh oh!

blueorangutan commented Aug 15, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

harikrishna-patnala commented Sep 3, 2025

Uh oh!

blueorangutan commented Sep 3, 2025

Uh oh!

blueorangutan commented Sep 3, 2025

Uh oh!

rohityadavcloud commented Sep 3, 2025

Uh oh!

blueorangutan commented Sep 3, 2025

Uh oh!

blueorangutan commented Sep 4, 2025

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

blueorangutan commented Oct 8, 2025

Uh oh!

harikrishna-patnala commented Oct 8, 2025

Uh oh!

blueorangutan commented Oct 8, 2025

Uh oh!

blueorangutan commented Oct 8, 2025

Uh oh!

harikrishna-patnala commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

harikrishna-patnala commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

rohityadavcloud commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

rohityadavcloud commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

codecov bot commented Aug 14, 2025 •

edited

Loading